fix(ci): missing docs in framebuffer.rs + install clippy/rustfmt for 1.94.0#114
Merged
Merged
Conversation
…oolchain CI fixes for PR #113: 1. native-backend (missing_docs) — added doc comments for 11 public items in src/hpc/framebuffer.rs: Framebuffer.{width,height,tier}, WobbleState::new, FireState::new, FlybyFrame.{cam_x,cam_y,cam_zoom}, FlybyCache.{frames,height,len,is_empty}, PyramidShader::new. 2. clippy + format — rust-toolchain.toml pins 1.94.0, but the CI jobs install clippy/rustfmt only for the matrix `stable` toolchain. Added explicit `rustup component add ... --toolchain 1.94.0` step (with `|| true` so it doesn't fail if already installed) so cargo can find the components when it resolves the pinned toolchain. Pre-existing failures NOT addressed in this PR (would balloon scope): - nostd/thumbv6m: pre-existing unused-import warnings under -D warnings - cross_test/s390x: pre-existing endianness/cross-compile issues These fail on origin/master too and are not caused by this PR's changes. https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh
AdaWorldAPI
pushed a commit
that referenced
this pull request
Apr 30, 2026
Master's #114 added its own SIMD-accelerated wht_f32 with normalization (1/sqrt(n) factor, self-inverse). My branch had an unnormalized version plus 4 tests asserting unnormalized output. The duplicate caused E0428. - Removed my unnormalized wht_f32 (line 138) and orphaned doc block - Removed my 4 redundant tests (test_wht_zeros, test_wht_dc_impulse, test_wht_round_trip, test_wht_known_pair) — master already has test_wht_self_inverse, test_wht_energy_preservation, test_wht_large_simd which cover the normalized version's properties. Verified: cargo build clean, cargo test --lib 1705 passed, cargo fmt clean. Note: bgz-tensor consumers in lance-graph use wht_f32 as a one-way rotation (not round-trip), so the normalization factor doesn't change the relative ordering of values they consume. https://claude.ai/code/session_01NYGrxVopyszZYgLBxe4hgj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI failures from PR #113 follow-up:
1. native-backend (missing_docs) — fixed
Added doc comments for 11 undocumented public items in
src/hpc/framebuffer.rs:Framebuffer.{width, height, tier}WobbleState::new,FireState::new,PyramidShader::newFlybyFrame.{cam_x, cam_y, cam_zoom}FlybyCache.{frames, height, len, is_empty}2. clippy / format — fixed
rust-toolchain.tomlpins 1.94.0, but the CI jobs only install clippy/rustfmtfor the matrix
stabletoolchain viadtolnay/rust-toolchain. When cargoresolves the pinned toolchain it can't find clippy/rustfmt for 1.94.0.
Added explicit
rustup component add ... --toolchain 1.94.0 || truestepin both jobs so the components exist for the toolchain that cargo actually
uses. The
|| truemakes it idempotent if already installed.Pre-existing failures NOT addressed
These fail on
mastertoo and are not caused by this PR's changes:-D warnings. Thehpc::*modules are gated onfeature = "std"so mynew SIMD code doesn't affect this target.
Test plan
RUSTFLAGS="-D warnings -C target-cpu=x86-64-v3" cargo build --lib --features approx,serde,rayon— missing-docs errors gonecargo check --libcleanrust-toolchain.tomlunchanged (revert avoided breaking offline local builds)https://claude.ai/code/session_01SbYsmmbPf9YQuYbHZN52Zh
Generated by Claude Code